Skip to content

Fix: Apply correct padding when two modals opened in succession (#2781) #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
robertwramos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Apply correct padding when two modals opened in succession (#2781) #2782

robertwramos wants to merge 1 commit into from

Conversation

@robertwramos
Copy link

@robertwramos robertwramos commented Nov 15, 2023 •
edited
Loading

  • [ x] Bug fix
  • New feature
  • Chore
  • Breaking change
  • [x ] There is an open issue which this change addresses
  • [x ] I have read the CONTRIBUTING document.
  • [ x] My commits follow the Git Commit Guidelines
  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • [x ] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

Fixes #2781

@robertwramos
Copy link
Author

robertwramos commented Nov 12, 2024

@illiteratewriter Anything we can do to move this along?

@arjunadeltoso
Copy link

arjunadeltoso commented Mar 26, 2025 •
edited
Loading

@robertwramos, we just hit this bug today. Do you know if it was fixed on a separate PR? (Our reactstrap is 9.1.5.)

@robertwramos
Copy link
Author

robertwramos commented Apr 2, 2025

@arjunadeltoso Not to my knowledge. But if you need a workaround what I ended up doing is setting the body paddingRight to null after a 500ms delay in the modal toggle callback.
Something like this:

const closeModal = () => {
  setTimeout(() => {
    document.body.style.paddingRight = null;
  }, 500);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Padding issue when closing a modal and opening another at the same time

2 participants

@robertwramos @arjunadeltoso