Skip to content

feat: add ref to modal #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
illiteratewriter wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add ref to modal #2712

illiteratewriter wants to merge 2 commits into from

Conversation

@illiteratewriter
Copy link
Member

@illiteratewriter illiteratewriter commented Mar 8, 2023 •
edited
Loading

#2089

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@illiteratewriter illiteratewriter requested review from aaronmars and removed request for aaronmars September 28, 2023 10:30
@aaronmars
Copy link
Collaborator

aaronmars commented Sep 28, 2023

It seems like the pattern throughout the library is to use the innerRef pattern instead. I'm not defending that pattern (I think this forwardRef / ref pattern is the best and recommended way to go). I'm just wondering if this is the right place to introduce a new way of handling refs? Perhaps a larger effort to switch patterns with a breaking change?

@illiteratewriter
Copy link
Member Author

illiteratewriter commented Oct 6, 2023

This can be merged along with #2695 I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronmars aaronmars Awaiting requested review from aaronmars

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@illiteratewriter @aaronmars