Improve check for openssl on macOS #1104
Merged
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only call `openssl version` once; - Make the check work with future version of LibreSSL after 2.2.7. This assumes that Apple might keep updating LibreSSL shipping with macOS, but that they will never provide header files.
jeremy
approved these changes
Jun 12, 2017
There was a problem hiding this comment.
Considering OpenSSL has been deprecated on macOS for years and is now missing headers entirely, what do you think about always treating macOS OpenSSL as missing?
needs_mac_openssl() {
is_mac &&
[[ "$RUBY_CONFIGURE_OPTS" != *--with-openssl-dir=* ]] &&
! use_homebrew_openssl
}
|
@jeremy That's a good point. If there wasn't ever a |
|
my understanding is following summary about OpenSSL on macOS.
So, OpenSSL/LibreSSL of macOS is completely broken. I agreed to use jeremy's condition for openssl veriication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only call
openssl versiononce;Make the check work with future version of LibreSSL after 2.2.7. This assumes that Apple might keep updating LibreSSL shipping with macOS, but that they will never provide header files.
Followup to #1095
/cc @hsbt @osyoyu