Skip to content

Commit

Permalink
Merge pull request #393 from razorpay/release/2.0.36
Browse files Browse the repository at this point in the history
[release] 2.0.36
  • Loading branch information
PriyankaMarbill authored Nov 11, 2024
2 parents eac74f9 + 5f97067 commit 33f89e0
Show file tree
Hide file tree
Showing 12 changed files with 55 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [UNRELEASED][unreleased]

## [2.0.36][2.0.36]
### Changed
- Metadata updates
- Support for XNSE (NSE Clearing Limited) added. `XNSE0000001` is the branch.

## [2.0.35][2.0.35]
### Changed
- Metadata updates
Expand Down
2 changes: 1 addition & 1 deletion ifsc.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)

Gem::Specification.new do |s|
s.name = 'ifsc'
s.version = '2.0.35'
s.version = '2.0.36'
s.date = '2022-10-28'
s.summary = 'IFSC code database to help you validate IFSC codes'
s.description = 'A simple gem by @razorpay to help you validate your IFSC codes. IFSC codes are bank codes within India'
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ifsc",
"version": "2.0.35",
"version": "2.0.36",
"description": "This is part of the IFSC toolset released by Razorpay. You can find more details about the entire release at [ifsc.razorpay.com](https://ifsc.razorpay.com). Includes only a validation library as of now.",
"main": "src/node/index.js",
"directories": {
Expand Down
2 changes: 1 addition & 1 deletion src/IFSC.json

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/banknames.json
Original file line number Diff line number Diff line change
Expand Up @@ -1477,6 +1477,7 @@
"WUCX": "Washim Urban Co-operative Bank.",
"WZUX": "Wardha Zilla Parishad Emp Urban Co-operative Bank",
"XJKG": "J&K Grameen Bank",
"XNSE": "NSE Clearing Limited",
"YADX": "Yavatmal District Central Co-operative Bank",
"YAVX": "Yavatmal Urban Co-operative Bank",
"YCBX": "Yashwant Co-operative Bank",
Expand Down
2 changes: 2 additions & 0 deletions src/go/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -1483,6 +1483,7 @@ const (
WUCX = "WUCX"
WZUX = "WZUX"
XJKG = "XJKG"
XNSE = "XNSE"
YADX = "YADX"
YAVX = "YAVX"
YCBX = "YCBX"
Expand Down Expand Up @@ -2993,6 +2994,7 @@ var bankCodes = map[string]bool{
"WUCX" : true,
"WZUX" : true,
"XJKG" : true,
"XNSE" : true,
"YADX" : true,
"YAVX" : true,
"YCBX" : true,
Expand Down
1 change: 1 addition & 0 deletions src/node/bank.js
Original file line number Diff line number Diff line change
Expand Up @@ -1481,6 +1481,7 @@ module.exports = Object.freeze({
WUCX: 'WUCX',
WZUX: 'WZUX',
XJKG: 'XJKG',
XNSE: 'XNSE',
YADX: 'YADX',
YAVX: 'YAVX',
YCBX: 'YCBX',
Expand Down
26 changes: 26 additions & 0 deletions src/patches/ifsc/xnse.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
# RTGS is open to non-banking institutions as wel
# but they do not show up on the list of enabled bank branches
# that RBI provides
# Links:
# - https://www.rbi.org.in/Scripts/Bs_viewRTGS.aspx
# - https://rbidocs.rbi.org.in/rdocs/RTGS/PDFs/RTGEB101014.PDF
# - https://rbidocs.rbi.org.in/rdocs/rtgs/pdfs/lps15022012.pdf
action: add_multiple
ifsc:
XNSE0000001:
ADDRESS: EXCHANGE PLAZA,PLOT NO C/1, G BLOCK,BANDRA-KURLA COMPLEX,BANDRA (E), MUMBAI 400051
BRANCH: Mumbai
BANK: NSE Clearing Limited
CENTRE: Mumbai
CITY: MUMBAI
CONTACT: null
DISTRICT: Mumbai
IMPS: false
MICR: XNSE00001
NEFT: false
RTGS: true
STATE: MAHARASHTRA
ISO3166: IN-MH
SWIFT: null
UPI: false
1 change: 1 addition & 0 deletions src/php/Bank.php
Original file line number Diff line number Diff line change
Expand Up @@ -1487,6 +1487,7 @@ class Bank
const WUCX = 'WUCX';
const WZUX = 'WZUX';
const XJKG = 'XJKG';
const XNSE = 'XNSE';
const YADX = 'YADX';
const YAVX = 'YAVX';
const YCBX = 'YCBX';
Expand Down
1 change: 1 addition & 0 deletions src/ruby/bank.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1483,6 +1483,7 @@ module Bank
WUCX = :WUCX
WZUX = :WZUX
XJKG = :XJKG
XNSE = :XNSE
YADX = :YADX
YAVX = :YAVX
YCBX = :YCBX
Expand Down
9 changes: 9 additions & 0 deletions tests/php/BankNameTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ class Name extends TestCase
public function testDefined() {
$this->assertEquals('PUNB', constant('Razorpay\IFSC\Bank::PUNB'));
$this->assertEquals('BDBL', constant('Razorpay\IFSC\Bank::BDBL'));
$this->assertEquals('XNSE', constant('Razorpay\IFSC\Bank::XNSE'));

$this->assertEquals('BDBL', Bank::BDBL);
}
Expand Down Expand Up @@ -43,5 +44,13 @@ public function testBankDetails() {
'name' => 'Fino Payments Bank',
'bank_code' => '099'
], Bank::getDetails('FINO'));

$this->assertEqualsCanonicalizing([
'code' => 'XNSE',
'ifsc' => 'XNSE0000001',
'micr' => null,
'name' => 'NSE Clearing Limited',
'bank_code' => null
], Bank::getDetails('XNSE'));
}
}
6 changes: 6 additions & 0 deletions tests/php/SubletTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ public function testBasicNames()
$this->assertEquals("Darjeeling District Central Co-operative Bank", $name);
}

public function testXNSE()
{
$name = IFSC::getBankName('XNSE0000001');

$this->assertEquals("NSE Clearing Limited", $name);
}
/**
* Ensure that the sublet list only
* includes genuine subleases
Expand Down

0 comments on commit 33f89e0

Please sign in to comment.