-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove process.env from pass execution #15462
Conversation
Thank you for your first contribution! 🎉 🔔 @capipo you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
Could you check this @capipo |
I'm passing Perhaps if you filter out variables that start with |
Nevermind, I see that that variable is passed later |
Hi @capipo, I'm not really sure about that since the extension is overwriting the export async function pass(cmd: string, storeDir: string = ''): Promise<string> {
const passCmd = `pass ${cmd}`;
const { stdout, stderr } = await execAsync(passCmd, {
timeout: 10000,
env: {
...process.env
PATH: await envPath(),
PASSWORD_STORE_DIR: storeDir,
},
});
if (stderr) {
throw new Error(stderr);
}
return stdout;
} Let me try removing the locale issue and fix this since maybe it can have conflicts with other peoples custom variables since |
@capipo pls check the above solution 👆🏽 |
@pernielsentikaer I think this can be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Looks good to me, approved 🔥
Published to the Raycast Store: |
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
This change is done due to errors in the extension using nix-darwing messing with the locales
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder