Adding fused_l2_nn_argmin wrapper to Pylibraft
#924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
cjnolet
changed the title
fused_l2_nn_argmin wrapper to Pylibraft
dantegd
approved these changes
Oct 19, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2022
Follow up to #924, removing a `print` that managed to sneak in. cc @cjnolet Authors: - Tim Head (https://github.com/betatim) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This coincides pretty well w/ the
pairwise_distance_arminbuilding block that's being exposed in Scikit-learn, except it's faster and saves a lot of gpu memory by fusing the argmin w/ the pairwise distances so we don't ever have to store the n^2 distances.cc @betatim