Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variadic template type check for mdarrays #741

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Fix variadic template type check for mdarrays #741

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f426360
Fix type check
hlinsen Jul 14, 2022
3f32f79
Remove comment
hlinsen Jul 14, 2022
f2630e7
Use conjunction
hlinsen Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove comment
  • Loading branch information
@hlinsen
hlinsen committed Jul 14, 2022
commit 3f32f7933ecd7089006b8132b912d73639ca29c5
5 changes: 0 additions & 5 deletions cpp/include/raft/detail/mdarray.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,11 +329,6 @@ MDSPAN_INLINE_FUNCTION auto unravel_index_impl(I idx, stdex::extents<Extents...>
* put it as the last nameless template parameter of a function:
* `typename = ensure_integral_extents<Extents...>`
*/
/*
template <typename... Extents>
using ensure_integral_extents =
std::enable_if_t<(true && ... && std::is_integral_v<Extents>), void>;
*/
template <typename... Extents>
using ensure_integral_extents = std::enable_if_t<std::is_integral_v<Extents...>>;
} // namespace raft::detail