Use rapids-cmake for cuco #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
improvement
|
@cjnolet do these errors look similar to the other ones that you encountered recently where we discussed tolerances? I recall that we observed some failure on a recent PR (I can't remember if it was conda compilers, scikit-build, conda packaging, etc). This PR shouldn't change anything since the cuco commit we're getting is the same. |
|
rerun tests |
|
Interesting, now I am also seeing failures in |
|
rerun tests |
robertmaynard
approved these changes
Jun 27, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that a consistent cuco version is used across all of RAPIDS. See rapidsai/rapids-cmake#201 and rapidsai/cudf#11139