Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cuco version #714

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 16, 2022

This updates cuco to the latest version used in cudf.

@vyasr vyasr self-assigned this Jun 16, 2022
@vyasr vyasr requested a review from a team as a code owner June 16, 2022 16:47
@github-actions github-actions bot added the cpp label Jun 16, 2022
@vyasr vyasr added improvement Improvement / enhancement to an existing function and removed cpp labels Jun 16, 2022
@github-actions github-actions bot added the cpp label Jun 16, 2022
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding this from being merged until cugraph is ready.

@vyasr
Copy link
Contributor Author

vyasr commented Jun 16, 2022

@cjnolet cugraph is updated in rapidsai/cugraph#2360 but we'll need to get this PR merged (once tests pass here) before tests will pass on that PR.

@cjnolet
Copy link
Member

cjnolet commented Jun 16, 2022

rerun tests

@vyasr
Copy link
Contributor Author

vyasr commented Jun 16, 2022

rerun tests

See you tomorrow...

@cjnolet
Copy link
Member

cjnolet commented Jun 17, 2022

@vyasr not sure if you saw but there was a failure from a flaky test so I restarted it.

@cjnolet
Copy link
Member

cjnolet commented Jun 17, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d729754 into rapidsai:branch-22.08 Jun 17, 2022
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Jun 17, 2022
RAFT is updating to the newest version of `cuco` in this PR: rapidsai/raft#714

This PR makes the necessary changes to cugraph to support the latest `cuco`.  It should be merged after the RAFT PR.
 * update version of cuco
 * update constructor calls to cuco::static_map

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: #2360
@vyasr
Copy link
Contributor Author

vyasr commented Jun 17, 2022

@vyasr not sure if you saw but there was a failure from a flaky test so I restarted it.

I saw, I was just being sad about our (now fixed!) slow CI.

@vyasr vyasr deleted the feature/update_cuco branch June 17, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants