find_package(raft) can now be called multiple times safely #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would try to add the `raft::Thrust` target multiple times, causing a CMake error as the target already existed. This is required as find_package(X) can be invoked any number of times and will execute the `X-config.cmake` each time.
robertmaynard
added
bug
cjnolet
approved these changes
Feb 28, 2022
|
@gpucibot merge |
robertmaynard
deleted the
bug/allow_multiple_inclusion_of_raft-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would try to add the
raft::Thrusttarget multiple times, causing a CMake error as the target already existed.This is required as find_package(X) can be invoked any number of times and will execute the
X-config.cmakeeach time.