Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Hiding implementation details for sparse API #381

Merged
merged 24 commits into from
Dec 7, 2021
Merged

[REVIEW] Hiding implementation details for sparse API #381

merged 24 commits into from
Dec 7, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Nov 16, 2021

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 16, 2021
@cjnolet cjnolet requested review from a team as code owners November 16, 2021 16:13
@cjnolet cjnolet changed the base branch from branch-21.12 to branch-22.02 November 16, 2021 16:14
@github-actions github-actions bot removed the CMake label Nov 16, 2021
@cjnolet cjnolet requested a review from a team as a code owner November 16, 2021 19:15
@cjnolet cjnolet changed the title [WIP] Hiding implementation details for sparse API [REVIEW] Hiding implementation details for sparse API Nov 16, 2021
ajschmidt8
ajschmidt8 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@github-actions github-actions bot removed the gpuCI label Nov 17, 2021
@github-actions github-actions bot removed the CMake label Nov 17, 2021
divyegala
divyegala approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great! Comments are only above formatting issues for doxygen comments on files that were moved in detail.

cpp/include/raft/sparse/convert/detail/dense.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/detail/coo.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/detail/coo.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/detail/coo.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/detail/coo.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/selection/detail/knn.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/selection/detail/knn.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/selection/detail/knn.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/selection/detail/knn.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/selection/detail/knn.cuh Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Dec 7, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b29ec65 into rapidsai:branch-22.02 Dec 7, 2021
@cjnolet cjnolet mentioned this pull request Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjnolet @ajschmidt8 @divyegala