Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparse semirings cleanup + hash table & batching strategies #269

Merged
merged 49 commits into from
Jun 23, 2021
Merged

Sparse semirings cleanup + hash table & batching strategies #269

merged 49 commits into from
Jun 23, 2021

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Jun 9, 2021 •
edited
Loading

This branch includes several new features and optimizations:

  1. Introduces a hash table strategy to sparsify the vector in the coo spmv shared memory
  2. Adds a batching strategy for rows with nnz too large to fit into shared memory
  3. Removes the need for the cusparse csrgemm
  4. Uses raft handle in distances_config_t rather than accepting each resource explicitly
  5. Removes the naive CSR semiring code

This PR is also required to merge #261, which introduces the remaining distances

divyegala and others added 30 commits March 18, 2021 13:11
@divyegala
moving sparse dist optim to raft
5b28699
@divyegala
bucketing bloom filter
8e841ac
@divyegala
trying stuff
efcf972
@divyegala
dropping tpb as template in strategies
8f5cc26
@cjnolet
New distances
78aff5a
@cjnolet
Uncommenting hash strategy
9aa58f2
@cjnolet
Udating hash strategy
cf57c9f
@cjnolet
Updating to add hash table and bloom strategies
530dd87
@cjnolet
Updates
62b3df4
@cjnolet
More updates
28d6e2d
@cjnolet
Updating hash strategy
c79ee7a
@cjnolet
Merge branch 'branch-0.19' into HEAD
e5d93dd
@cjnolet
Updates
628b169
@cjnolet
Merge branch 'branch-0.19' into fea-020-sparse_spmv_optim
fc708a9
@divyegala
trying to merge chunking bug fixes
d9ecc40
@divyegala
correcting int to value_idx
d299cb8
@divyegala
correction to expansion and start index
900ad8c
@cjnolet
Adding correlation distance
634bc99
@cjnolet
Baseline
82cdbe1
@cjnolet
Enabling baseline
4e819c0
@cjnolet
Enabling optimized primitive
6bd450f
@cjnolet
Fixing style
f1c1d06
@cjnolet
Cleanup
219a813
@cjnolet
Style
0fee984
@cjnolet
Removing unecessary deltas
b7105d7
@cjnolet
Updating distances_config_t to use handle directly
e264514
@cjnolet
Merge branch 'branch-0.20' into semiring_primitives_optim_final
65f82bd
@cjnolet
Adding tests for newer distances
2975fe3
@cjnolet
NOrmalizing
0d064cc
@cjnolet
Separating new distances from optimizations
2057985
@divyegala divyegala requested review from a team as code owners June 9, 2021 18:23
@divyegala divyegala changed the title Semirings SPMV optimizations + hash table Sparse semirings cleanup + hash table & batching strategies Jun 9, 2021
@divyegala divyegala added 3 - Ready for Review enhancement New feature or request non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed enhancement New feature or request labels Jun 9, 2021
cjnolet
cjnolet requested changes Jun 15, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the hash and chunking strategies look great. Mostly minor things. I'm ready to finally get this in!

This was referenced Jun 15, 2021
Merged
Closed
cjnolet
cjnolet requested changes Jun 23, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go. Just one more trivial thing.

cjnolet
cjnolet approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Jun 23, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit caa44e6 into rapidsai:branch-21.08 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divyegala @cjnolet