-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding NCCL clique to the RAFT handle #2431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change, Victor. The changes mostly look good, but I have very minor changes to naming (and filenames).
a6e834b
to
b663890
Compare
/merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-24.10 #2431 +/- ##
=============================================
Coverage 87.17% 87.17%
=============================================
Files 25 25
Lines 546 546
=============================================
Hits 476 476
Misses 70 70 ☔ View full report in Codecov by Sentry. |
No description provided.