Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct initializer list order found by cuvs #2317

Conversation

robertmaynard
Copy link
Contributor

Align our constuctor order to match what C++ spec says will occur:

Then, non-static data members are initialized in the order they were declared in the class definition (again regardless of the order of the mem-initializers).

Otherwise consumer of raft will get warnings when building with -Wall -Wextra and using the index type.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels May 14, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner May 14, 2024 15:12
@github-actions github-actions bot added the cpp label May 14, 2024
@robertmaynard robertmaynard removed their assignment May 15, 2024
@cjnolet
Copy link
Member

cjnolet commented May 16, 2024

/merge

@rapids-bot rapids-bot bot merged commit 7e37451 into rapidsai:branch-24.06 May 16, 2024
69 checks passed
@robertmaynard robertmaynard deleted the bug/correct_initializer_list_order branch November 1, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants