Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Ensure hnswlib can be found from RAFT's build dir #2145

Merged
merged 4 commits into from
Feb 2, 2024
Merged

[FIX] Ensure hnswlib can be found from RAFT's build dir #2145

merged 4 commits into from
Feb 2, 2024

Conversation

trxcllnt
Copy link
Collaborator

@trxcllnt trxcllnt commented Feb 1, 2024

This PR fixes using RAFT from a build dir, i.e. cmake -S cuml/cpp -B cuml/cpp/build -Draft_ROOT=raft/cpp/build.

Without this fix, CMake errors when cuML does find_package(RAFT) with the following error:

CMake Error at raft/cpp/build/latest/raft-targets.cmake:56 (set_target_properties):
  The link interface of target "raft::raft" contains:

    hnswlib::hnswlib

  but the target was not found.  Possible reasons include:


    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

@trxcllnt trxcllnt requested a review from a team as a code owner February 1, 2024 02:26
@trxcllnt trxcllnt added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cpp CMake labels Feb 1, 2024
@trxcllnt trxcllnt mentioned this pull request Feb 1, 2024
Merged
vyasr
vyasr requested changes Feb 1, 2024
View reviewed changes
@trxcllnt trxcllnt requested a review from vyasr February 2, 2024 06:54
@vyasr
Copy link
Contributor

vyasr commented Feb 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit 6328be7 into rapidsai:branch-24.04 Feb 2, 2024
61 checks passed
@trxcllnt trxcllnt deleted the fix/hnswlib-package-root-bug branch February 3, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@vyasr vyasr vyasr approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trxcllnt @vyasr @cjnolet @bdice