Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ivf-flat notebook #1758

Merged
merged 9 commits into from
Sep 22, 2023
Merged

Add ivf-flat notebook #1758

merged 9 commits into from
Sep 22, 2023

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Aug 21, 2023 •
edited
Loading

Example jupyter notebook to demonstrate usage of the IVF-Flat API

@tfeher tfeher self-assigned this Aug 21, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@tfeher tfeher added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search labels Aug 21, 2023
@tfeher tfeher marked this pull request as ready for review September 18, 2023 10:16
achirkin
achirkin approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Though as a nitpick: we're using three different ways to print the output across the notebook (varargs, f-strings, .format); I'd suggest we stick to one :) e.g. consistently use the f-strings - to make it look a bit more polished.

cjnolet
cjnolet reviewed Sep 20, 2023
View reviewed changes
notebooks/ivf_flat_example.ipynb Show resolved Hide resolved
notebooks/ivf_flat_example.ipynb Show resolved Hide resolved
notebooks/ivf_flat_example.ipynb Show resolved Hide resolved
notebooks/ivf_flat_example.ipynb Show resolved Hide resolved
notebooks/ivf_flat_example.ipynb Show resolved Hide resolved
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 21, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tfeher
Copy link
Contributor Author

tfeher commented Sep 21, 2023

Thanks @cjnolet for the review, I have addressed the issues.

cjnolet
cjnolet approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet
Copy link
Member

cjnolet commented Sep 22, 2023

/merge

@rapids-bot rapids-bot bot merged commit e1db49d into rapidsai:branch-23.10 Sep 22, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achirkin achirkin achirkin approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@tfeher tfeher

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfeher @cjnolet @achirkin