Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conda build for libraft static #1746

Merged
merged 10 commits into from
Aug 31, 2023

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Aug 16, 2023

No description provided.

@cjnolet cjnolet added feature request New feature or request non-breaking Non-breaking change labels Aug 16, 2023
@cjnolet cjnolet self-assigned this Aug 16, 2023
@cjnolet cjnolet requested a review from a team as a code owner August 16, 2023 22:46
@cjnolet cjnolet requested a review from a team as a code owner August 29, 2023 19:19
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 29, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cjnolet
Copy link
Member Author

cjnolet commented Aug 29, 2023

/ok to test

@cjnolet
Copy link
Member Author

cjnolet commented Aug 29, 2023

@robertmaynard I think this PR is ready for your blessing. I'm still unsure if I'm handling the RAFT_COMPILED variable correctly.

cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Aug 29, 2023

/ok to test

@cjnolet
Copy link
Member Author

cjnolet commented Aug 30, 2023

/ok to test

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Aug 30, 2023

/ok to test

@cjnolet
Copy link
Member Author

cjnolet commented Aug 30, 2023

/ok to test

@cjnolet
Copy link
Member Author

cjnolet commented Aug 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 70475c2 into rapidsai:branch-23.10 Aug 31, 2023
54 of 55 checks passed
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Sep 6, 2023
rapidsai/raft#1746 added static targets for RAFT that can be used directly now instead of building RAFT static explicitly

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #3842
rlratzel pushed a commit to rlratzel/cugraph that referenced this pull request Sep 8, 2023
rapidsai/raft#1746 added static targets for RAFT that can be used directly now instead of building RAFT static explicitly

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: rapidsai#3842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp feature request New feature or request non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants