[FEA] Use CAGRA in C++ template #1730
Conversation
cjnolet
added
improvement
cpp/template/CMakeLists.txt
Outdated
| @@ -28,11 +28,13 @@ rapids_cuda_init_architectures(test_raft) | |||
|
|
|||
| project(test_raft LANGUAGES CXX CUDA) | |||
|
|
|||
| find_package(OpenMP) | |||
There was a problem hiding this comment.
Why are we adding openmp to the dependencies here?
There was a problem hiding this comment.
CAGRA is using openmp and the link from raft::compiled to openmp is not automatic.
I've found that openmp needs to be found in the dependencies of the consumer`s project for the link to happend:
Lines 445 to 451 in b7d2a9a
There was a problem hiding this comment.
@robertmaynard do you have any ideas of why this might be happening? Are we missing something in the raft_lib side?
There was a problem hiding this comment.
There is no exporting of the need for OpenMP to consuming projects. https://github.com/rapidsai/raft/blob/branch-23.10/cpp/CMakeLists.txt#L130 would need to change to rapids_find_package with the proper export sets to remove the need for consumers to explicitly find OpenMP
|
/merge |
Proposal to change the C++ template from a distance computation to a vector search application using CAGRA.