Add support to __half and nv_bfloat16 to most math functions #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyrio
reviewed
May 30, 2023
cpp/include/raft/core/math.hpp
Outdated
Comment on lines
120
to
128
| #if (__CUDA_ARCH__ >= 530) | ||
| return ::hcos(x); | ||
| #else | ||
| // static_assert(false) would be evaluated during host compilation stage while __CUDA_ARCH__ is at | ||
| // device compilation stage Using this sizeof(T) != sizeof(T) makes it work as it's only triggered | ||
| // during template instantiation and thus at device compilation stage | ||
| static_assert(sizeof(T) != sizeof(T), "__half is only supported on __CUDA_ARCH__ >= 530"); | ||
| return T{}; | ||
| #endif |
There was a problem hiding this comment.
Question for @cjnolet : iirc RAPIDS is Pascal+, shall we have a centralized check of the minimum arch somewhere and remove these checks here, or would this have too many consequences on repos using raft?
…NDITION_ELSE_TRUE
Nyrio
requested changes
May 30, 2023
Nyrio
added
improvement
Nyrio
reviewed
May 30, 2023
|
Note: this PR solves #1542 |
Nyrio
approved these changes
May 31, 2023
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
This PR fixes some outdated pinnings in `branch-23.08` and applies some fixes to `update-version.sh`. See also: rapidsai/cuml#5440 #1554 (comment) Authors: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Ray Douglass (https://github.com/raydouglass) - Divye Gala (https://github.com/divyegala) - AJ Schmidt (https://github.com/ajschmidt8) URL: #1556
…o add_half_bfloat_support
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to __half and nb_bfloat16 to most math functions: