Enable shallow copy of handle_t's resources with different workspace_resource
#1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferent workspace_resource to be used.
cjnolet
added
improvement
cjnolet
changed the title
handle_t's resource pointers with different workspace_resource handle_t's resources with different workspace_resource
…s, handle, and device_resources
Merged
divyegala
approved these changes
Jan 24, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively affords users the flexibility to shallow copy a handle and it's underlying vectors and change out only the
workspace_resourceso that they can, for example, configure multiple different pools or managed pools for workspace resources.cc @Nyrio RE: hierarchical k-means API.