Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove faiss bfKnn call from fused_l2_knn unittest #1150

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Remove faiss bfKnn call from fused_l2_knn unittest #1150

merged 2 commits into from
Jan 18, 2023

Conversation

benfred
Copy link
Member

@benfred benfred commented Jan 17, 2023

No description provided.

@benfred benfred requested a review from a team as a code owner January 17, 2023 20:18
@benfred benfred added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 17, 2023
@github-actions github-actions bot added the cpp label Jan 17, 2023
cjnolet
cjnolet approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great to see a naive validation that's completely decoupled from the brute-force API.

@benfred
Copy link
Member Author

benfred commented Jan 18, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0cefbfb into rapidsai:branch-23.02 Jan 18, 2023
@benfred benfred deleted the remove_faiss_test_fused_l2 branch January 18, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benfred @cjnolet