Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handle docstring #1103

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Dec 14, 2022

No description provided.

@dantegd dantegd requested a review from a team as a code owner December 14, 2022 17:26
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! It looks like I missed testing out the pylibraft.common module when I added the doctests =(

Can you also add a line here https://github.com/rapidsai/raft/blob/branch-23.02/python/pylibraft/pylibraft/test/test_doctests.py#L95 so that we include this docstring in the tests?

@dantegd
Copy link
Member Author

dantegd commented Dec 14, 2022

@benfred just added the pylibraft.common objects to the test (Handle and Stream) indeed :)

@wphicks wphicks added bug Something isn't working non-breaking Non-breaking change labels Dec 14, 2022
@cjnolet
Copy link
Member

cjnolet commented Dec 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 81650cd into rapidsai:branch-23.02 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

4 participants