Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trivial deprecated header includes #1034

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix trivial deprecated header includes #1034

merged 1 commit into from
Nov 18, 2022

Conversation

achirkin
Copy link
Contributor

Fix some of the easier deprecated headers, leftovers from past refactorings.

@achirkin achirkin requested review from a team as code owners November 18, 2022 09:39
@achirkin achirkin added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Nov 18, 2022
@achirkin
Copy link
Contributor Author

Note, I haven't touched the more complicated cases, which could lead to compile-time errors. Here's the set of the remaining (untouched) warnings:

    SOURCE: include/raft/matrix/matrix.cuh(22):
    OFFENCE: include/raft/matrix/matrix.cuh
    MESSAGE: is deprecated and will be removed in a future release. Please use versions in individual header files instead.

    SOURCE: include/raft/spatial/knn/ball_cover_types.hpp(27):
    OFFENCE: include/raft/spatial/knn/ball_cover_types.hpp
    MESSAGE: is deprecated and will be removed in a future release. Please use the raft::neighbors version instead.

    SOURCE: include/raft/sparse/hierarchy/single_linkage.cuh(23):
    OFFENCE: include/raft/sparse/hierarchy/single_linkage.cuh
    MESSAGE: is deprecated and will be removed in a future release. Please use the raft/cluster version instead.

    SOURCE: include/raft/sparse/hierarchy/common.h:23:227:
    OFFENCE: include/raft/sparse/hierarchy/common.h
    MESSAGE: is deprecated and will be removed in a future release. Please use raft/cluster/single_linkage_types.hpp instead.

    SOURCE: include/raft/matrix/math.cuh(22):
    OFFENCE: include/raft/matrix/math.cuh
    MESSAGE: is deprecated and will be removed in a future release. Please use versions in individual header files instead.

    SOURCE: include/raft/sparse/mst/mst.cuh(24):
    OFFENCE: include/raft/sparse/mst/mst.cuh
    MESSAGE: is deprecated and will be removed in a future release. Please use the raft/sparse/solver version instead.

    SOURCE: include/raft/sparse/mst/mst_solver.cuh(24):
    OFFENCE: include/raft/sparse/mst/mst_solver.cuh
    MESSAGE: is deprecated and will be removed in a future release. Please use the raft/sparse/solver version instead.

    SOURCE: include/raft/spatial/knn/epsilon_neighborhood.cuh(27):
    OFFENCE: include/raft/spatial/knn/epsilon_neighborhood.cuh
    MESSAGE: is deprecated and will be removed in a future release. Please use the raft::neighbors version instead.

    SOURCE: include/raft/cluster/kmeans_params.hpp(18):
    OFFENCE: include/raft/cluster/kmeans_params.hpp
    MESSAGE: is deprecated and will be removed in a future release. Please use the raft/cluster/kmeans_types.hpp version instead.

    SOURCE: include/raft/sparse/neighbors/knn.cuh(27):
    OFFENCE: include/raft/sparse/neighbors/knn.cuh
    MESSAGE: is deprecated and will be removed in a future release. Please use the sparse/spatial version instead.

    SOURCE: include/raft/spatial/knn/ivf_flat_types.hpp(27):
    OFFENCE: include/raft/spatial/knn/ivf_flat_types.hpp
    MESSAGE: is deprecated and will be removed in a future release. Please use the raft::neighbors version instead.

    SOURCE: include/raft/sparse/selection/connect_components.cuh(27):
    OFFENCE: include/raft/sparse/selection/connect_components.cuh
    MESSAGE: is deprecated and will be removed in a future release. Please use the sparse/spatial version instead.

    SOURCE: include/raft/spatial/knn/ann_common.h(17):
    OFFENCE: include/raft/spatial/knn/ann_common.h
    MESSAGE: is deprecated and will be removed in a future release. Please use the other approximate KNN implementations defined in spatial/knn/*.

    SOURCE: include/raft/spatial/knn/ivf_flat.cuh:27:226:
    OFFENCE: include/raft/spatial/knn/ivf_flat.cuh
    MESSAGE: is deprecated and will be removed in a future release. Please use the raft::neighbors version instead.

@cjnolet
Copy link
Member

cjnolet commented Nov 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f2b8ae0 into rapidsai:branch-22.12 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achirkin @cjnolet