Fix the pytest error for async io #559
Conversation
kingcrimsontianyu
added
non-breaking
python/kvikio/tests/test_async_io.py
Outdated
| # Try to read file opened in write-only mode | ||
| with pytest.raises(RuntimeError, match="Operation not permitted"): | ||
| with pytest.raises(RuntimeError, match=expected_except_msg): |
There was a problem hiding this comment.
not a big fan of tests that check the error message content, but that's not on this PR.
There was a problem hiding this comment.
It seems like we're adding a lot of APIs (some public?) just for this error. Can we instead just verify that the error matches one of these strings, without worrying about which one? That would let us remove all the is_compat_mode_preferred logic.
There was a problem hiding this comment.
That makes sense. I'm wondering if ideally the public function is_compat_mode_preferred() and is_compat_mode_preferred_for_async() should be included in the Python API, or are they considered too low-level?
There was a problem hiding this comment.
The Python API addition has been reverted for now.
kingcrimsontianyu
force-pushed
the
fix-cufile-unit-test-failure
branch
from
c661e9d to
2ccd3f8
Compare
|
/merge |
This PR fixes #558
The root cause is that POSIX and cuFile report different error messages for the same invalid operation which attempts to read from a write-only file. The unit test needs to take account of these different messages.