Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow cuda-python 12.6.1 and 11.8.4 #537

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 6, 2024

Due to a bug in cuda-python we must disallow cuda-python 12.6.1 and 11.8.4. This PR disallows those versions.

See rapidsai/build-planning#116 for more information.

@bdice bdice requested a review from a team as a code owner November 6, 2024 12:38
@bdice bdice requested a review from jameslamb November 6, 2024 12:38
@bdice bdice added non-breaking Introduces a non-breaking change bug Something isn't working labels Nov 6, 2024
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit dac0803 into rapidsai:branch-24.12 Nov 6, 2024
57 checks passed
rapids-bot bot pushed a commit that referenced this pull request Nov 7, 2024
Follow-up to #537

Contributes to rapidsai/build-planning#116

That PR used `!=` requirements to skip a particular version of `cuda-python` that `kvikio` was incompatible with. A newer version of `cuda-python` (12.6.2 for CUDA 12, 11.8.5 for CUDA 11) was just released, and it also causes some build issues for RAPIDS libraries: rapidsai/cuvs#445 (comment)

To unblock CI across RAPIDS, this proposes **temporarily** switching to ceilings on the `cuda-python` dependency here.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants