Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling curl tests doesn't now disable kvikio cpp tests #503

Conversation

robertmaynard
Copy link
Contributor

Works around curl/curl#15351 . We cache the BUILD_TESTING cache variable when it exists so that our tests are enabled when building curl from source.

Works around curl/curl#15351 . We cache
the `BUILD_TESTING` cache variable when it exists so that our tests
are enabled when building curl from source.
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 21, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner October 21, 2024 20:04
@kingcrimsontianyu kingcrimsontianyu self-requested a review October 21, 2024 21:07
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 36c5c27 into rapidsai:branch-24.12 Oct 21, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants