Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements #493

Merged
merged 10 commits into from
Oct 11, 2024
Merged

Small improvements #493

merged 10 commits into from
Oct 11, 2024

Conversation

kingcrimsontianyu
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu commented Oct 9, 2024 •
edited
Loading

This PR makes a couple of small, general improvements.

  • Improve the use of std::tolower to avoid UB. References cppreference.
  • Improve the readability of POSIX read/write interface.
  • Improve the use of std::map to avoid a repeated search in the self-balancing BST, which takes O(n).

@kingcrimsontianyu kingcrimsontianyu self-assigned this Oct 9, 2024
@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 9, 2024
wence-
wence- reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few stylistic suggestions.

cpp/include/kvikio/posix_io.hpp Outdated Show resolved Hide resolved
cpp/include/kvikio/posix_io.hpp Outdated Show resolved Hide resolved
cpp/include/kvikio/posix_io.hpp Outdated Show resolved Hide resolved
cpp/include/kvikio/posix_io.hpp Outdated Show resolved Hide resolved
cpp/include/kvikio/posix_io.hpp Outdated Show resolved Hide resolved
@kingcrimsontianyu kingcrimsontianyu marked this pull request as ready for review October 9, 2024 19:45
@kingcrimsontianyu kingcrimsontianyu requested a review from a team as a code owner October 9, 2024 19:45
@madsbk madsbk added breaking Introduces a breaking change and removed non-breaking Introduces a non-breaking change labels Oct 10, 2024
madsbk
madsbk reviewed Oct 10, 2024
View reviewed changes
cpp/include/kvikio/defaults.hpp Outdated Show resolved Hide resolved
cpp/include/kvikio/posix_io.hpp Show resolved Hide resolved
madsbk
madsbk approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @kingcrimsontianyu

mythrocks
mythrocks approved these changes Oct 10, 2024
View reviewed changes
Copy link

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, this.

@madsbk madsbk closed this Oct 11, 2024
@madsbk madsbk reopened this Oct 11, 2024
@madsbk
Copy link
Member

madsbk commented Oct 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit 22668fa into rapidsai:branch-24.12 Oct 11, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule left review comments

@mythrocks mythrocks mythrocks approved these changes

@madsbk madsbk madsbk approved these changes

@wence- wence- Awaiting requested review from wence-

Assignees

@kingcrimsontianyu kingcrimsontianyu

Labels
breaking Introduces a breaking change improvement Improves an existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kingcrimsontianyu @madsbk @wence- @mythrocks @vuule