Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility of static class methods #492

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Visibility of static class methods #492

merged 3 commits into from
Oct 7, 2024

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Oct 7, 2024

We need to export static class methods that returns a reference to a static variable like we do with inline functions: #442

@madsbk madsbk added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 7, 2024
@madsbk madsbk changed the title Visibility of static class method Visibility of static class methods Oct 7, 2024
@madsbk madsbk marked this pull request as ready for review October 7, 2024 08:36
@madsbk madsbk requested a review from a team as a code owner October 7, 2024 08:36
@madsbk madsbk requested a review from wence- October 7, 2024 11:43
@madsbk
Copy link
Member Author

madsbk commented Oct 7, 2024

/merge

@rapids-bot rapids-bot bot merged commit 2bd6bb4 into rapidsai:branch-24.12 Oct 7, 2024
56 checks passed
@madsbk madsbk deleted the visibility_of_static_class_method branch October 7, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wence- wence- Awaiting requested review from wence-

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsbk @wence- @bdice