Fix no-cuda build #484
Merged
Fix no-cuda build #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
bug
wence-
approved these changes
Oct 3, 2024
cpp/include/kvikio/utils.hpp
Outdated
| #define KVIKIO_NVTX_FUNC_RANGE_2(msg, val) \ | ||
| do { \ | ||
| } while (0) | ||
| #endif |
There was a problem hiding this comment.
Could shovel this into the shim, but because it only appears here that seems like overkill.
bdice
reviewed
Oct 3, 2024
cpp/include/kvikio/utils.hpp
Outdated
| @@ -300,6 +302,7 @@ struct libkvikio_domain { | |||
|
|
|||
| // Macro overloads of KVIKIO_NVTX_FUNC_RANGE | |||
| #define KVIKIO_NVTX_FUNC_RANGE_1() NVTX3_FUNC_RANGE_IN(libkvikio_domain) | |||
| #ifdef KVIKIO_CUDA_FOUND | |||
There was a problem hiding this comment.
Why is this guard only needed for KVIKIO_NVTX_FUNC_RANGE_2 but not KVIKIO_NVTX_FUNC_RANGE_1? The KVIKIO_NVTX_FUNC_RANGE_1 appears to call an NVTX macro but that wouldn't be defined if nvtx wasn't included above... right?
There was a problem hiding this comment.
Good catch, it worked because BASIC_NO_CUDA_EXAMPLE never materialize KVIKIO_NVTX_FUNC_RANGE_1.
I have included all of them in the ifdef guard now: 168dd0c
bdice
approved these changes
Oct 3, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #482