Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch ups to Array #475

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Sep 28, 2024

  • Add return type to asarray (makes easy to use with other typed values)
  • Include asarray in pxd for faster access within other Cython modules

@jakirkham jakirkham requested a review from a team as a code owner September 28, 2024 01:18
@jakirkham jakirkham added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 28, 2024
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jakirkham

Comment on lines +293 to +301
cpdef Array asarray(obj):
"""Coerce other objects to ``Array``. No-op for existing ``Array``s.

Args:
obj: Object exposing the Python buffer protocol or ``__cuda_array_interface__``

Returns:
Array: An instance of the ``Array`` class
"""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this look?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jakirkham !

@jakirkham jakirkham requested a review from pentschev September 30, 2024 22:13
@madsbk
Copy link
Member

madsbk commented Oct 1, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9643fab into rapidsai:branch-24.12 Oct 1, 2024
56 checks passed
@jakirkham jakirkham deleted the refresh_array branch October 1, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants