-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch ups to Array
#475
Touch ups to Array
#475
Conversation
5c10774
to
89c7601
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @jakirkham
cpdef Array asarray(obj): | ||
"""Coerce other objects to ``Array``. No-op for existing ``Array``s. | ||
|
||
Args: | ||
obj: Object exposing the Python buffer protocol or ``__cuda_array_interface__`` | ||
|
||
Returns: | ||
Array: An instance of the ``Array`` class | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @jakirkham !
/merge |
asarray
(makes easy to use with other typed values)asarray
inpxd
for faster access within other Cython modules