Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pytest dependency in kvikio conda recipe #461

Merged
merged 1 commit into from
Sep 16, 2024
Merged

remove pytest dependency in kvikio conda recipe #461

merged 1 commit into from
Sep 16, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Sep 10, 2024 •
edited
Loading

kvikio's conda recipe only has an import: test (basically, makes conda-build run python -c "import kvikio" after building).

It doesn't ask conda-build to run any other tests.

Therefore, its test: dependency on pytest is unnecessary. This proposes removing it.

Notes for Reviewers

conda docs on how the test: section of a recipe works: https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#test-section

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 10, 2024
@jameslamb jameslamb requested a review from a team as a code owner September 10, 2024 18:35
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 04663b4 into rapidsai:branch-24.10 Sep 16, 2024
56 checks passed
@jameslamb jameslamb deleted the remove-test-dep branch September 16, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @raydouglass