Update build.sh
#445
Merged
Update build.sh
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
improvement
bdice
approved these changes
Aug 28, 2024
build.sh
Outdated
| @@ -115,6 +115,8 @@ if hasArg -v; then | |||
| fi | |||
| if hasArg -g; then | |||
| BUILD_TYPE=Debug | |||
| export SKBUILD_INSTALL_STRIP=false | |||
| export SKBUILD_CMAKE_BUILD_TYPE=""Debug"" | |||
There was a problem hiding this comment.
Why double double quotes?
Suggested change
| export SKBUILD_CMAKE_BUILD_TYPE=""Debug"" | |
| export SKBUILD_CMAKE_BUILD_TYPE="Debug" |
There was a problem hiding this comment.
@wence- were the double quotes deliberate?
There was a problem hiding this comment.
I just copied as-is from the scikit-build documentation: https://scikit-build-core.readthedocs.io/en/latest/configuration.html#configuring-cmake-arguments-and-defines
There was a problem hiding this comment.
It looks like a typo, at least other code, including in their own testing, just use SKBUILD_CMAKE_BUILD_TYPE=Debug.
Fixed
Co-authored-by: Bradley Dice <[email protected]>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.