Remove NumPy <2 pin #441
Merged
Remove NumPy <2 pin #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
added
non-breaking
|
Seems this is already using numpy 2 and working fine (i.e. kvikio doesn't run into the CuPy 13.2 issues, and doesn't depend on rmm or so limiting it). So it seems this is probably ready. |
wence-
approved these changes
Aug 20, 2024
jameslamb
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Looks good to me, based on my understanding of rapidsai/ucx-py#1064 (comment).
Please remove the language in the description about this being unsafe combined with cupy < 13.3.0 before merging.
|
Sebastian rewrote the description based on the feedback in the UCX-Py PR and updated it here as well |
jakirkham
approved these changes
Aug 22, 2024
|
/merge |
|
Thanks Sebastian, James, and Lawrence! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the NumPy<2 pin. This is desirable for RAPIDS projects that do not have a strong numpy/cupy dependency.
Not doing any math, they don't run into subtle issues, but the pin was still necessary briefly before NumPy 2 was initially released.
(Other RAPIDS projects rely heavily on CuPy/NumPy and need the soon to be released 13.3.0 to function properly, e.g. due to promotion related changes in NumPy.)