C++ Test #440
C++ Test #440
Conversation
madsbk
added
improvement
madsbk
force-pushed
the
gtests
branch
4 times, most recently
from
5bd6ffc to
eebb208
Compare
ci/run_ctests.sh
Outdated
| # TODO: how to use ctest instead of executing the test directly? | ||
| # The following line fails with a "ctest doesn't exist" in CI. | ||
| # Do we need to install ctest in the CI images? | ||
| # ctest --no-tests=error --output-on-failure "$@" |
There was a problem hiding this comment.
Do we need to install ctest?
There was a problem hiding this comment.
You need to install cmake. Add to the test_cpp group.
There was a problem hiding this comment.
This PR probably needs to update build.sh. Also check the libkvikio-tests conda packaging and install script to make sure we aren't missing anything there.
Co-authored-by: Bradley Dice <[email protected]>
For now, I think I think |
ci/run_ctests.sh
Outdated
| rapids-logger "Run BASIC_IO_EXAMPLE" | ||
| ./BASIC_IO_EXAMPLE | ||
| rapids-logger "Run BASIC_NO_CUDA_EXAMPLE" | ||
| ./BASIC_NO_CUDA_EXAMPLE | ||
|
|
||
| # Run gtests | ||
| rapids-logger "Run gtests" |
There was a problem hiding this comment.
I have a weak preference to avoid rapids-logger commands in the run_*.sh scripts because I think those are intended for reuse outside of the CI workflows (in DLFW, perhaps?). In other use cases, the gha-tools utilities may not be present. Either use echo or replace the rapids-logger statements with code comments.
There was a problem hiding this comment.
@trxcllnt may have comments about appropriate use cases here.
There was a problem hiding this comment.
I have removed the rapids-logger use
|
/merge |
Implement very basic C++ tests.