Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks clean up #424

Merged
merged 10 commits into from
Jul 30, 2024
Merged

Benchmarks clean up #424

merged 10 commits into from
Jul 30, 2024

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jul 25, 2024 •
edited
Loading

Closes #176

Since we didn't install the python benchmarks previously, this PR is non-breaking even though it moves and renames them.

@madsbk madsbk added bug Something isn't working improvement Improves an existing functionality non-breaking Introduces a non-breaking change and removed improvement Improves an existing functionality labels Jul 25, 2024
@madsbk madsbk added improvement Improves an existing functionality and removed bug Something isn't working labels Jul 25, 2024
@madsbk madsbk marked this pull request as ready for review July 25, 2024 15:06
@madsbk madsbk requested review from a team as code owners July 25, 2024 15:06
@madsbk madsbk requested a review from AyodeAwe July 25, 2024 15:06
wence-
wence- approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane.

@madsbk
Copy link
Member Author

madsbk commented Jul 30, 2024

/merge

@rapids-bot rapids-bot bot merged commit c992e50 into rapidsai:branch-24.08 Jul 30, 2024
56 checks passed
@madsbk madsbk deleted the benchmarks branch July 30, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@wence- wence- wence- approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving from pynvml to nvidia-ml-py
3 participants
@madsbk @wence- @jameslamb