Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and test with CUDA 12.5.1 #401

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Build and test with CUDA 12.5.1 #401

merged 4 commits into from
Jul 16, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 11, 2024 •
edited
Loading

This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.

Contributes to rapidsai/build-planning#73

@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jul 11, 2024
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review July 16, 2024 13:26
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners July 16, 2024 13:26
@KyleFromNVIDIA KyleFromNVIDIA requested a review from AyodeAwe July 16, 2024 13:26
@jameslamb jameslamb requested review from jameslamb and removed request for AyodeAwe July 16, 2024 15:03
jameslamb
jameslamb requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more documentation places that should probably be updated.

kvikio/cpp/doxygen/main_page.md

Lines 40 to 41 in 363e2d6

# Create new environment (CUDA 12.0)
mamba create -n libkvikio-env -c rapidsai -c conda-forge cuda-version=12.0 libkvikio

kvikio/cpp/doxygen/main_page.md

Lines 51 to 52 in 363e2d6

# Create new environment (CUDA 12.0)
mamba create -n libkvikio-env -c rapidsai-nightly -c conda-forge python=3.11 cuda-version=12.0 libkvikio

kvikio/docs/source/install.rst

Lines 20 to 21 in 363e2d6

# Create new environment (CUDA 12.2)
mamba create -n kvikio-env -c rapidsai -c conda-forge python=3.11 cuda-version=12.2 kvikio

kvikio/docs/source/install.rst

Lines 31 to 32 in 363e2d6

# Create new environment (CUDA 12.2)
mamba create -n kvikio-env -c rapidsai-nightly -c conda-forge python=3.11 cuda-version=12.2 kvikio

xref: rapidsai/dask-cuda#1357 (review)

And this one that'll be broken by the changed conda env file name:

kvikio/docs/source/install.rst

Lines 48 to 49 in 363e2d6

# CUDA 12.2
mamba env create --name kvikio-dev --file conda/environments/all_cuda-122_arch-x86_64.yaml

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner July 16, 2024 17:42
@jakirkham jakirkham requested a review from jameslamb July 16, 2024 18:42
jameslamb
jameslamb approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit ff94539 into rapidsai:branch-24.08 Jul 16, 2024
56 checks passed
@jakirkham
Copy link
Member

Thanks Kyle and James! 🙏

@jakirkham jakirkham mentioned this pull request Jul 16, 2024
Merged
rapids-bot bot pushed a commit that referenced this pull request Jul 16, 2024
@jakirkham
Rename .devcontainers for CUDA 12.5 (#406)
ab3778c 
Follow up to PR: #401
Partially addresses issue: rapidsai/build-planning#73

Renames the `.devcontainer`s for CUDA 12.5

cc @KyleFromNVIDIA @jameslamb (for awareness)

Authors:
  - https://github.com/jakirkham

Approvers:
  - Paul Taylor (https://github.com/trxcllnt)
  - James Lamb (https://github.com/jameslamb)

URL: #406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleFromNVIDIA @jakirkham @jameslamb