Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conda recipe for kvikio #381

Merged
merged 4 commits into from
May 16, 2024
Merged

Fix conda recipe for kvikio #381

merged 4 commits into from
May 16, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented May 15, 2024 •
edited by jakirkham
Loading

Use build.sh in meta.yaml, and pass -DFIND_KVIKIO_CPP=ON to CMake.

xref: #379 (comment)

Fixes #378

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners May 15, 2024 22:12
bdice
bdice reviewed May 15, 2024
View reviewed changes
@bdice bdice mentioned this pull request May 15, 2024
Merged
@jakirkham jakirkham added bug Something isn't working non-breaking Introduces a non-breaking change python Affects the Python API of KvikIO conda labels May 15, 2024
@jakirkham jakirkham mentioned this pull request May 15, 2024
Closed
@KyleFromNVIDIA KyleFromNVIDIA requested a review from bdice May 16, 2024 13:33
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 261445b into rapidsai:branch-24.06 May 16, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice bdice approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees
No one assigned
Labels
bug Something isn't working conda non-breaking Introduces a non-breaking change python Affects the Python API of KvikIO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conda package isn't build with GDS support!
5 participants
@KyleFromNVIDIA @vyasr @bdice @AyodeAwe @jakirkham