Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Warnings as errors for Python tests #375

Merged
merged 3 commits into from
May 2, 2024

Conversation

mroeschke
Copy link
Contributor

As part of rapidsai/build-planning#26, warnings from the Python test suite will cause a test to fail

@mroeschke mroeschke requested a review from a team as a code owner May 1, 2024 21:32
@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 2, 2024
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mroeschke

@mroeschke
Copy link
Contributor Author

/merge

@wence-
Copy link
Contributor

wence- commented May 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit 5032f8b into rapidsai:branch-24.06 May 2, 2024
35 checks passed
@mroeschke mroeschke deleted the test/wae branch May 2, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants