POSIX IO: use async memcpy #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
improvement
madsbk
force-pushed
the
posix_use_stream
branch
from
909ffd7 to
f83475e
Compare
vuule
reviewed
Apr 30, 2024
| { | ||
| for (auto& [_, stream] : _streams) { | ||
| try { | ||
| CUDA_DRIVER_TRY(cudaAPI::instance().StreamDestroy(stream)); |
There was a problem hiding this comment.
Doesn't this segfault when destroying the singleton? We had to let the libcudf stream pool "leak" to avoid this.
There was a problem hiding this comment.
Not on my workstation or in CI. Maybe it is because we are using a newer CTK. Do you have a link to the libcudf issue?
There was a problem hiding this comment.
huh. I can't repro the crash now.
I don't think we had an issue open.
…o posix_use_stream
vuule
approved these changes
May 6, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #311