-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deflate codec #364
Merged
Merged
Add deflate codec #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ok to test |
madsbk
added
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
labels
Apr 8, 2024
/ok to test |
madsbk
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @ap--
PS: ran pre-commit run --all-file
to fix styles
/merge |
ap--
added a commit
to pfizer-opensource/bigwig-loader
that referenced
this pull request
Apr 10, 2024
Deflate codec support was added upstream in rapidsai/kvikio#364
crystalninja5
added a commit
to crystalninja5/ubiquitous-carnival
that referenced
this pull request
Aug 11, 2024
Deflate codec support was added upstream in rapidsai/kvikio#364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
We've been using nvcomp's deflate decompression in https://github.com/pfizer-opensource/bigwig-loader to load data from a legacy genome track format and it would make distribution of our code a lot easier if kvikio would ship the deflate codec wrappers too.
This PR exposes nvcomp's deflate algorithm in kvikio and adds it to the nvcomp_codec tests.
Cheers,
Andreas