Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deflate codec #364

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Add deflate codec #364

merged 3 commits into from
Apr 9, 2024

Conversation

ap--
Copy link
Contributor

@ap-- ap-- commented Apr 6, 2024

Hello everyone,

We've been using nvcomp's deflate decompression in https://github.com/pfizer-opensource/bigwig-loader to load data from a legacy genome track format and it would make distribution of our code a lot easier if kvikio would ship the deflate codec wrappers too.

This PR exposes nvcomp's deflate algorithm in kvikio and adds it to the nvcomp_codec tests.

Cheers,
Andreas

@ap-- ap-- requested a review from a team as a code owner April 6, 2024 11:42
Copy link

copy-pr-bot bot commented Apr 6, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@madsbk
Copy link
Member

madsbk commented Apr 8, 2024

/ok to test

@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 8, 2024
@madsbk
Copy link
Member

madsbk commented Apr 8, 2024

/ok to test

Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ap--

PS: ran pre-commit run --all-file to fix styles

@madsbk
Copy link
Member

madsbk commented Apr 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9a00b0a into rapidsai:branch-24.06 Apr 9, 2024
35 checks passed
ap-- added a commit to pfizer-opensource/bigwig-loader that referenced this pull request Apr 10, 2024
crystalninja5 added a commit to crystalninja5/ubiquitous-carnival that referenced this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants