Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coding of RAPIDS version where possible #351

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Remove hard-coding of RAPIDS version where possible #351

merged 2 commits into from
Mar 12, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

  • Add VERSION file
  • Read VERSION file from CMake
  • Read VERSION file from Python
  • Read kvikio.__version__ from docs build
  • Read VERSION file from shell scripts
  • Use variable substitution in Doxyfile
  • Remove unused ci/checks/style.sh
  • Update ci/release/update-version.sh

Issue: rapidsai/build-planning#15

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners March 11, 2024 19:50
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 11, 2024
robertmaynard
robertmaynard approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes LGTM

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit af9bad8 into rapidsai:branch-24.04 Mar 12, 2024
35 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@bdice bdice bdice approved these changes

@vuule vuule vuule approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KyleFromNVIDIA @jakirkham @robertmaynard @bdice @vuule @AyodeAwe