Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.sh #332

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Update build.sh #332

merged 2 commits into from
Feb 1, 2024

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Feb 1, 2024

Update the build script to support #325

@madsbk madsbk requested a review from a team as a code owner February 1, 2024 07:57
@madsbk madsbk added bug Something isn't working non-breaking Introduces a non-breaking change labels Feb 1, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally remove the legate portion?

@madsbk
Copy link
Member Author

madsbk commented Feb 1, 2024

Did you intentionally remove the legate portion?

Yes sorry, should have mentioned. Making this the first step to phase out Legate. It depend on skbuild classic, which isn't a KvikIO dependency anymore, and everything has been ported to legate-io anyways. I will remove it completely in v24.04.

@madsbk madsbk requested a review from vyasr February 1, 2024 18:44
@madsbk
Copy link
Member Author

madsbk commented Feb 1, 2024

Thanks @vyasr and @bdice

@madsbk
Copy link
Member Author

madsbk commented Feb 1, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0771b66 into rapidsai:branch-24.02 Feb 1, 2024
33 checks passed
@madsbk madsbk deleted the update-build.sh branch July 25, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants