Skip to content

Remove duplicated thread-pool API #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2023
Merged

Remove duplicated thread-pool API #308

merged 1 commit into from
Oct 25, 2023

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Oct 25, 2023

Removing an old and broken thread-pool module:

kvikio.thread_pool.num_threads_reset()
kvikio.thread_pool.get_num_threads()

Use the default module instead:

kvikio.defaults.num_threads_reset()
kvikio.defaults.get_num_threads()

@madsbk madsbk added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 25, 2023
@madsbk madsbk mentioned this pull request Oct 25, 2023
Closed
@madsbk madsbk marked this pull request as ready for review October 25, 2023 08:34
@madsbk madsbk requested a review from a team as a code owner October 25, 2023 08:34
@madsbk
Copy link
Member Author

madsbk commented Oct 25, 2023

/merge

@rapids-bot rapids-bot bot merged commit d56d88c into rapidsai:branch-23.12 Oct 25, 2023
@madsbk madsbk deleted the fix_thread_defaults branch November 1, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsbk @wence-