Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numcodecs pin #300

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Add numcodecs pin #300

merged 3 commits into from
Oct 10, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 9, 2023 •
edited by jakirkham
Loading

numcodecs 0.12 appears to have some breaking changes. I've submitted a fix upstream, but for this release of RAPIDS we'll need to upper bound the version to be safe.

xref: zarr-developers/numcodecs#475

@vyasr vyasr added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 9, 2023
@vyasr vyasr self-assigned this Oct 9, 2023
@vyasr vyasr requested review from a team as code owners October 9, 2023 23:13
@vyasr
Copy link
Contributor Author

vyasr commented Oct 9, 2023

This should resolve issues like what we are currently seeing in nightly builds: https://github.com/rapidsai/kvikio/actions/runs/6452705318

jakirkham
jakirkham reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vyas!

Think we want exclusive (instead of inclusive) constraints on numcodecs. Otherwise it pulls in the affected version

@vyasr
Copy link
Contributor Author

vyasr commented Oct 9, 2023 •
edited
Loading

Whoops 🤦 thanks @jakirkham. Fixed.

On the plus side, now we know from this run on the last commit that the issue from the nightly runs reproduces on this branch, so we'll have confirmation that this pin is a fix if CI passes this time around.

@jakirkham
Copy link
Member

No worries. Thanks Vyas! 🙏

Should we add this constraint to the Conda recipe too (given zarr is already there)?

kvikio/conda/recipes/kvikio/meta.yaml

Line 72 in 7703b40

- zarr

Wondering if this might fix the couple CI failures still remaining

@madsbk
Copy link
Member

madsbk commented Oct 10, 2023

What about using numcodecs != 0.12.0?

@madsbk
Copy link
Member

madsbk commented Oct 10, 2023 •
edited
Loading

CI is still installing v0.12.0, is that expected?
https://github.com/rapidsai/kvikio/actions/runs/6462853621/job/17545375472?pr=300#step:7:596

@jakirkham
Copy link
Member

Yeah was thinking about != too. Would plan on having this fixed in 0.12.1. So just a question of whether we are comfortable with that approach

Think we still need a couple more numcodecs pins to fix CI (as alluded to above)

bdice
bdice approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vyasr for fixing this. I think I'm in favor of <0.12.0 for 23.10, though we could change this to !=0.12.0 in 23.12 if a patch is released as 0.12.1.

@vyasr
Copy link
Contributor Author

vyasr commented Oct 10, 2023

Apologies just seeing the discussion above, but yes I made the necessary fix to the conda recipe as well.

I would also prefer to use <0.12.0 for 23.10 given that RAPIDS releases tomorrow and it would be better to be completely decoupled from the numcodecs fix.

@madsbk
Copy link
Member

madsbk commented Oct 10, 2023 via email

@raydouglass raydouglass merged commit 5ef30fb into rapidsai:branch-23.10 Oct 10, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

@vyasr vyasr deleted the fix/numcodecs branch October 10, 2023 18:32
@jameslamb jameslamb mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@bdice bdice bdice approved these changes

Assignees

@vyasr vyasr

Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @jakirkham @madsbk @bdice @raydouglass