Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable devcontainer CI. #285

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Re-enable devcontainer CI. #285

merged 5 commits into from
Dec 8, 2023

Conversation

trxcllnt
Copy link
Contributor

No description provided.

@trxcllnt trxcllnt requested a review from a team as a code owner September 21, 2023 22:30
@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 22, 2023
@madsbk madsbk changed the base branch from branch-23.10 to branch-23.12 November 29, 2023 15:49
@bdice bdice changed the base branch from branch-23.12 to branch-24.02 December 8, 2023 20:09
@bdice
Copy link
Contributor

bdice commented Dec 8, 2023 •
edited
Loading

The only diff left on this PR was adding --verbose. I think the other branch changes were already fixed upstream. However, looking at this PR made me realize that devcontainers are currently disabled in CI for kvikio. I am attempting to re-enable them to see if they work now.

@bdice bdice changed the title Update devcontainer workflow branch Re-enable devcontainer CI. Dec 8, 2023
@bdice
Copy link
Contributor

bdice commented Dec 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit ef26290 into rapidsai:branch-24.02 Dec 8, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trxcllnt @bdice @madsbk @raydouglass