Async I/O using by-value arguments #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
improvement
tell-rebanta
reviewed
Sep 5, 2023
tell-rebanta
approved these changes
Sep 11, 2023
wence-
requested changes
Sep 12, 2023
cpp/include/kvikio/stream.hpp
Outdated
| * `write_async` can call `.get_args()` to get the by-reference arguments required by cuFile's | ||
| * stream API. However, this also means that the caller of `read_async` and `write_async` MUST keep | ||
| * the returned `StreamFuture` alive until the operations is done otherwise `StreamFuture` will free | ||
| * `ArgByVal` before cuFile had a change to use them! |
There was a problem hiding this comment.
💡 suggestion: Could we make this safer by having ~StreamFuture sync the stored stream?
cpp/include/kvikio/stream.hpp
Outdated
Comment on lines
52
to
63
| struct ArgByVal { | ||
| std::size_t size; | ||
| off_t file_offset; | ||
| off_t devPtr_offset; | ||
| ssize_t bytes_done; | ||
| }; | ||
| struct ArgByRef { | ||
| std::size_t* size_p; | ||
| off_t* file_offset_p; | ||
| off_t* devPtr_offset_p; | ||
| ssize_t* bytes_done_p; | ||
| }; |
There was a problem hiding this comment.
❓ question: Since these are not exposed to the outside world (I think/hope), should they rather be private?
cpp/include/kvikio/stream.hpp
Outdated
Comment on lines
68
to
69
| ArgByVal* _val{nullptr}; | ||
| ArgByRef _ref{nullptr}; |
There was a problem hiding this comment.
❓ question: Do we actually need both of these stored in the class, does it suffice instead to do something like:
class StreamFuture {
private:
struct data {
std::size_t size;
off_t file_offset;
off_t devptr_offset;
ssize_t bytes_done;
}
data* _values{};
public:
StreamFuture(...args)
{
_values = static_cast<data *>(...);
_values->size = size;
_values->...;
}
std::tuple<...> get_args() {
return {&_values->size, &_values->file_offset, ...};
}
}Or is there some subtlety I am missing?
There was a problem hiding this comment.
Right, my initially idea was to support mixing of by-value and by-ref arguments, which would use ArgByRef to tell which arguments were which. Fixed
|
@wence- I think I have addressed all your comments. |
…o async_future
Co-authored-by: Lawrence Mitchell <[email protected]>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a version of
read_asyncandwrite_asyncthat takes by-value arguments and returns aStreamFuture.This is to make the common case easy where the user knows the file and buffer size.
cc. @tell-rebanta