Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async: fall back to blocking #272

Merged
merged 7 commits into from
Sep 3, 2023
Merged

async: fall back to blocking #272

merged 7 commits into from
Sep 3, 2023

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Aug 30, 2023

read_async() and write_async() now works in compat mode by falling back to the blocking implementation

@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 30, 2023
@madsbk madsbk marked this pull request as ready for review August 30, 2023 13:39
@madsbk madsbk requested a review from a team as a code owner August 30, 2023 13:39
wence-
wence- requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small docstring fixes/queries.

@madsbk madsbk requested a review from wence- August 31, 2023 11:49
@madsbk
Copy link
Member Author

madsbk commented Sep 1, 2023

Thanks @wence-, anything else?

wence-
wence- approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@madsbk
Copy link
Member Author

madsbk commented Sep 3, 2023

/merge

@rapids-bot rapids-bot bot merged commit 26dff9a into rapidsai:branch-23.10 Sep 3, 2023
@madsbk madsbk deleted the async_fallback branch September 4, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsbk @wence-