Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zarr+CuPy+GDS+nvCOMP made easy #267

Merged
merged 8 commits into from
Aug 25, 2023
Merged

Zarr+CuPy+GDS+nvCOMP made easy #267

merged 8 commits into from
Aug 25, 2023

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Aug 23, 2023 •
edited
Loading

Introducing open_cupy_array(), which is a CUDA friendly version of zarr.open_array that reads and writes to CuPy arrays.

@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 23, 2023
@madsbk madsbk changed the title Zarr cupy made easy Zarr+CuPy+GDS+nvCOMP made easy Aug 23, 2023
@madsbk madsbk force-pushed the zarr_cupy_made_easy branch from fcf1a8a to 1c050bd Compare August 23, 2023 13:28
@madsbk madsbk marked this pull request as ready for review August 23, 2023 14:33
@madsbk madsbk requested a review from a team as a code owner August 23, 2023 14:33
quasiben
quasiben reviewed Aug 24, 2023
View reviewed changes
python/kvikio/zarr.py Outdated Show resolved Hide resolved
quasiben
quasiben reviewed Aug 24, 2023
View reviewed changes
python/kvikio/zarr.py Outdated Show resolved Hide resolved
madsbk and others added 2 commits August 24, 2023 16:28
@madsbk @quasiben
Spelling
768f503 
Co-authored-by: Benjamin Zaitlen <[email protected]>
@madsbk @quasiben
Spelling
656d439 
Co-authored-by: Benjamin Zaitlen <[email protected]>
wence-
wence- reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor queries

python/kvikio/zarr.py Show resolved Hide resolved
python/kvikio/zarr.py Show resolved Hide resolved
python/kvikio/zarr.py Show resolved Hide resolved
wence-
wence- approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mads.

@madsbk
Copy link
Member Author

madsbk commented Aug 25, 2023

/merge

@rapids-bot rapids-bot bot merged commit 37b9d00 into rapidsai:branch-23.10 Aug 25, 2023
This was referenced Oct 3, 2023
Draft
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiben quasiben quasiben approved these changes

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsbk @wence- @quasiben