Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Cython 3.0.0 #258

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Update to Cython 3.0.0 #258

merged 6 commits into from
Aug 14, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 28, 2023

This PR bumps the pinning and fixes the new warnings that appeared

@vyasr vyasr added breaking Introduces a breaking change improvement Improves an existing functionality labels Jul 28, 2023
@vyasr vyasr self-assigned this Jul 28, 2023
@vyasr vyasr marked this pull request as ready for review August 4, 2023 16:08
@vyasr vyasr requested review from a team as code owners August 4, 2023 16:08
@vyasr vyasr requested review from Alexey-Kamenev and vuule August 4, 2023 18:23
jakirkham
jakirkham reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vyas! 🙏

Proposed a comment that may capture what we are after with rvalues

@vyasr vyasr requested a review from jakirkham August 14, 2023 19:10
@vyasr
Copy link
Contributor Author

vyasr commented Aug 14, 2023 •
edited
Loading

Apologies for the delay. I've addressed reviews, I think this PR should be good to go now.

@jakirkham
Copy link
Member

@Alexey-Kamenev @vuule , could you please review the latest changes?

Alexey-Kamenev
Alexey-Kamenev approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@Alexey-Kamenev Alexey-Kamenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 55829bf into rapidsai:branch-23.10 Aug 14, 2023
@jakirkham
Copy link
Member

Thanks Vyas and everyone for reviews! 🙏

Let's follow up on anything else in subsequent issues/PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina left review comments

@jakirkham jakirkham jakirkham approved these changes

@raydouglass raydouglass raydouglass approved these changes

@Alexey-Kamenev Alexey-Kamenev Alexey-Kamenev approved these changes

@vuule vuule vuule approved these changes

Assignees

@vyasr vyasr

Labels
breaking Introduces a breaking change improvement Improves an existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vyasr @jakirkham @raydouglass @shwina @Alexey-Kamenev @vuule