Use nvcomp conda package. #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is probably blocked on rapidsai/cudf#13566 (comment), I will revisit this PR later but wanted to get the draft open for now. |
bdice
added
DO NOT MERGE
improvement
|
Thanks Bradley! 🙏 Do we need to do anything with |
Nope. No changes should be needed there. |
jakirkham
approved these changes
Jun 26, 2023
raydouglass
approved these changes
Jun 26, 2023
|
I verified that the Python build logs look correct. The conda output shows lines like |
|
/merge |
|
Thanks Bradley! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses conda-forge packages of
nvcomprather than fetching a tarball. This means that the nvcomp binary should not be shipped in the kvikio conda package, but is instead listed as a dependency. This will reduce kvikio's conda package size.Resolves #242.